Re: [PATCH v3 2/4] arm64: dts: sc7180: Specify "data-lanes" for DSI host output

From: Doug Anderson
Date: Mon Nov 01 2021 - 13:10:14 EST


Hi,

On Fri, Oct 29, 2021 at 3:27 PM Philip Chen <philipchen@xxxxxxxxxxxx> wrote:
>
> MSM DSI host driver actually parses "data-lanes" in DT and compare
> it with the number of DSI lanes the bridge driver sets for
> mipi_dsi_device. So we need to always specify "data-lanes" for the
> DSI host output. As of now, "data-lanes" is added to ti-sn65dsi86 dts
> fragment, but missing in parade-ps8640 dts fragment, which requires
> a fixup.
>
> Since we'll do 4-lane DSI regardless of which bridge chip is used,
> instead of adding "data-lanes" to parade-ps8640 dts fragment, let's
> just move "data-lanes" from the bridge dts to sc7180-trogdor.dtsi.
>
> Signed-off-by: Philip Chen <philipchen@xxxxxxxxxxxx>
> ---
>
> (no changes since v1)
>
> arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi | 1 -
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 4 ++++
> 2 files changed, 4 insertions(+), 1 deletion(-)

I think it's fine to take this change even if we also decide to fix
the driver as well.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>