Re: [PATCH 2/6] dt-bindings: input/ts/zinitix: Convert to YAML, fix and extend
From: Rob Herring
Date: Mon Nov 01 2021 - 17:39:32 EST
On Wed, 27 Oct 2021 23:13:46 +0500, Nikita Travkin wrote:
> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> This converts the Zinitix BT4xx and BT5xx touchscreen bindings to YAML, fix
> them up a bit and extends them.
>
> We list all the existing BT4xx and BT5xx components with compatible strings.
> These are all similar, use the same bindings and work in similar ways.
>
> We rename the supplies from the erroneous vdd/vddo to the actual supply
> names vcca/vdd as specified on the actual component. It is long established
> that supplies shall be named after the supply pin names of a component.
> The confusion probably stems from that in a certain product the rails to the
> component were named vdd/vddo. Drop some notes on how OS implementations should
> avoid confusion by first looking for vddo, and if that exists assume the
> legacy binding pair and otherwise use vcca/vdd.
>
> Add reset-gpios as sometimes manufacturers pulls a GPIO line to the reset
> line on the chip.
>
> Add optional touchscreen-fuzz-x and touchscreen-fuzz-y properties.
>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Michael Srba <Michael.Srba@xxxxxxxxx>
> Cc: phone-devel@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> [Fixed dt_schema_check error]
> Signed-off-by: Nikita Travkin <nikita@xxxxxxx>
> ---
> This patch was previously submited here:
> https://lore.kernel.org/linux-input/20210625113435.2539282-1-linus.walleij@xxxxxxxxxx/
>
> Changes since the original patch:
> - Use enum for compatible list instead of oneOf + const
> ---
> .../input/touchscreen/zinitix,bt400.yaml | 115 ++++++++++++++++++
> .../bindings/input/touchscreen/zinitix.txt | 40 ------
> 2 files changed, 115 insertions(+), 40 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/zinitix,bt400.yaml
> delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/zinitix.txt
>
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>