Re: [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible

[Jesse Taube]

On 11/1/21 16:13, Rob Herring wrote:
> On Sun, Oct 24, 2021 at 11:40:22AM -0400, Jesse Taube wrote:
> > Add i.MXRT documentation for compatible string.
> >
> > Cc: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Jesse Taube <Mr.Bossman075@xxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index a90c971b4f1f..4b4340def2aa 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -21,6 +21,7 @@ properties:
> >            - fsl,ls1028a-lpuart
> >            - fsl,imx7ulp-lpuart
> >            - fsl,imx8qm-lpuart
> > +          - fsl,imxrt-lpuart
>
> Actually, 'rt' is not a single part is it? If the variations are same 
> die, but fused off then no need to distinguish. Otherwise, these should 
> be SoC specific.
I don't exactly know what "but fused off" means I would assume
disconnected but on-die? The imxrtxxx is a series that has the same UART
controller across them. Should I add ACK?
> Same applies to other compatible strings.
>
> >        - items:
> >            - const: fsl,imx8qxp-lpuart
> >            - const: fsl,imx7ulp-lpuart
> > --
> > 2.33.0