Re: [PATCH v7 3/3] drm/bridge: anx7625: config hs packets end aligned to avoid screen shift

From: Robert Foss
Date: Tue Nov 02 2021 - 06:49:10 EST


On Tue, 2 Nov 2021 at 02:56, Xin Ji <xji@xxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Nov 01, 2021 at 11:16:15AM +0800, Jitao Shi wrote:
> > Hi Xin,
> >
> > Please help to review the changes in anx7625.c
> >
> > On Thu, 2021-09-16 at 06:31 +0800, Jitao Shi wrote:
> > > This device requires the packets on lanes aligned at the end to fix
> > > screen shift or scroll.
> > >
> > > Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
> > > ---
> > > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > index 14d73fb1dd15..d76fb63fa9f7 100644
> > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > @@ -1327,6 +1327,7 @@ static int anx7625_attach_dsi(struct
> > > anx7625_data *ctx)
> > > MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > > MIPI_DSI_MODE_NO_EOT_PACKET |
> > > MIPI_DSI_MODE_VIDEO_HSE;
> > > + dsi->hs_packet_end_aligned = true;
>
> Looks good, it's OK for me.
> Reviewed-by: Xin Ji <xji@xxxxxxxxxxxxxxxx>

Acked-by: Robert Foss <robert.foss@xxxxxxxxxx>