Re: [PATCH] net/9p: autoload transport modules
From: Thomas Weißschuh
Date: Tue Nov 02 2021 - 06:59:44 EST
Hi,
On 2021-11-02 19:51+0900, Dominique Martinet wrote:
> Sorry for the late reply
>
> Thomas Weißschuh wrote on Sun, Oct 17, 2021 at 03:46:11PM +0200:
> > Automatically load transport modules based on the trans= parameter
> > passed to mount.
> > The removes the requirement for the user to know which module to use.
>
> This looks good to me, I'll test this briefly on differnet config (=y,
> =m) and submit to Linus this week for the next cycle.
Thanks. Could you also fix up the typo in the commit message when applying?
("The removes" -> "This removes")
> Makes me wonder why trans_fd is included in 9pnet and not in a 9pnet-fd
> or 9pnet-tcp module but that'll be for another time...
To prepare for the moment when those transport modules are split into their own
module(s), we could already add MODULE_ALIAS_9P() calls to net/9p/trans_fd.c.
Thomas