Re: [PATCH v3 3/8] dt-bindings: reset: Add bindings for SP7021 reset driver

From: Philipp Zabel
Date: Tue Nov 02 2021 - 07:51:32 EST


On Mon, 2021-11-01 at 13:01 +0800, Qin Jian wrote:
> Add documentation to describe Sunplus SP7021 reset driver bindings.
>
> Signed-off-by: Qin Jian <qinjian@xxxxxxxxxxx>
> ---
>  .../bindings/reset/sunplus,reset.yaml | 40 ++++++++
>  MAINTAINERS | 2 +
>  include/dt-bindings/reset/sp-sp7021.h | 99 +++++++++++++++++++
>  3 files changed, 141 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reset/sunplus,reset.yaml
>  create mode 100644 include/dt-bindings/reset/sp-sp7021.h
>
> diff --git a/Documentation/devicetree/bindings/reset/sunplus,reset.yaml b/Documentation/devicetree/bindings/reset/sunplus,reset.yaml
> new file mode 100644
> index 000000000..bf55f4ee2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/sunplus,reset.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/reset/sunplus,reset.yaml#";
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> +
> +title: Sunplus SoC Reset Controller
> +
> +maintainers:
> + - Qin Jian <qinjian@xxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - sunplus,sp7021-reset # Reset Controller on SP7021 and compatible SoCs
> + - sunplus,q645-reset # Reset Controller on Q645 and compatible SoCs

The commit message only mentions SP7021. Should Q645 be added later, or
is this patch missing the binding header for Q655?

regards
Philipp