RE: [PATCH v7 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support

[pillair]

> -----Original Message-----
> From: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> Sent: Saturday, October 30, 2021 12:34 AM
> To: agross@xxxxxxxxxx; bjorn.andersson@xxxxxxxxxx;
> mathieu.poirier@xxxxxxxxxx; ohad@xxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx;
> pillair@xxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx; linux-remoteproc@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> sibis@xxxxxxxxxxxxxx; mpubbise@xxxxxxxxxxxxxx; kuabhs@xxxxxxxxxxxx
> Subject: RE: [PATCH v7 2/3] dt-bindings: remoteproc: qcom: Add SC7280
> WPSS support
> 
> Quoting pillair@xxxxxxxxxxxxxx (2021-10-29 03:46:03)
> >
> > > > +
> > > > +        glink-edge {
> > > > +            interrupts-extended = <&ipcc IPCC_CLIENT_WPSS
> > > > +                                         IPCC_MPROC_SIGNAL_GLINK_QMP
> > > > +                                         IRQ_TYPE_EDGE_RISING>;
> > > > +            mboxes = <&ipcc IPCC_CLIENT_WPSS
> > > > +                            IPCC_MPROC_SIGNAL_GLINK_QMP>;
> > > > +
> > > > +            label = "wpss";
> > > > +            qcom,remote-pid = <13>;
> > >
> > > There are a few properties here that don't seem to be required. Is
> > > that intentional?
> >
> > Hi Stephen,
> > All the properties in the example are listed as required (except for status,
> which will be removed in the subsequent patchset).
> > Do you mean the glink-edge node properties ?
> 
> Yes I mean all the properties in the glink-edge node. Are they required?
> If so then we need to list them in the schema.

Hi Stephen,
I have sent v8 with glink-edge properties also included in the dt-bindings.

Thanks,
Rakesh Pillai.