Re: [BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from atomisp_video_pipe

From: Andy Shevchenko
Date: Tue Nov 02 2021 - 10:45:03 EST


On Tue, Nov 2, 2021 at 3:10 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote:

> > + if(!pipe->asd) {
>
> Run your patches through scripts/checkpatch.pl.

While it's good advice, we are dealing with quite a bad code under
staging, so the requirements may be relaxed.

> > + dev_err(pipe->isp->dev, "%s(): asd is NULL, device is %s\n",
> > + __func__, pipe->vdev.name);
> > + return;
> > + }

--
With Best Regards,
Andy Shevchenko