Re: [PATCH v7 1/2] Bluetooth: Add struct of reading AOSP vendor capabilities
From: Marcel Holtmann
Date: Tue Nov 02 2021 - 14:41:27 EST
Hi Joseph,
> This patch adds the struct of reading AOSP vendor capabilities.
> New capabilities are added incrementally. Note that the
> version_supported octets will be used to determine whether a
> capability has been defined for the version.
>
> Signed-off-by: Joseph Hwang <josephsih@xxxxxxxxxxxx>
>
> ---
>
> Changes in v7:
> - Use the full struct aosp_rp_le_get_vendor_capa. If the
> version_supported is >= 98, check bluetooth_quality_report_support.
> - Use __le16 and __le32.
> - Use proper bt_dev_err and bt_dev_warn per review comments.
> - Skip unnecessary bt_dev_dbg.
> - Remove unnecessary rp->status check.
> - Skip unnecessary check about version_supported on versions that we
> do not care about. For now, we only care about quality report support.
> - Add the define for the length of the struct.
> - Mediatek will submit a separate patch to enable aosp.
>
> Changes in v6:
> - Add historical versions of struct aosp_rp_le_get_vendor_capabilities.
> - Perform the basic check about the struct length.
> - Through the version, bluetooth_quality_report_support can be checked.
>
> Changes in v5:
> - This is a new patch.
> - Add struct aosp_rp_le_get_vendor_capabilities so that next patch
> can determine whether a particular capability is supported or not.
>
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/aosp.c | 83 +++++++++++++++++++++++++++++++-
> 2 files changed, 83 insertions(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel