Re: [PATCH] bpf, x86:remove unneeded variable

[Alexei Starovoitov]

On Tue, Nov 2, 2021 at 10:47 PM <cgel.zte@xxxxxxxxx> wrote:
>
> From: Zhang Mingyu <zhang.mingyu@xxxxxxxxxx>
>
> Fix the following coccinelle REVIEW:
> ./arch/x86/net/bpf_jit_comp32.c:1274:5-8

trash that checker and please send patches after you tested them.

> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Zhang Mingyu <zhang.mingyu@xxxxxxxxxx>
> ---
>  arch/x86/net/bpf_jit_comp32.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/x86/net/bpf_jit_comp32.c b/arch/x86/net/bpf_jit_comp32.c
> index da9b7cfa4632..bce7b9b5a653 100644
> --- a/arch/x86/net/bpf_jit_comp32.c
> +++ b/arch/x86/net/bpf_jit_comp32.c
> @@ -1271,7 +1271,6 @@ static void emit_epilogue(u8 **pprog, u32 stack_depth)
>  static int emit_jmp_edx(u8 **pprog, u8 *ip)
>  {
>         u8 *prog = *pprog;
> -       int cnt = 0;
>
>  #ifdef CONFIG_RETPOLINE
>         EMIT1_off32(0xE9, (u8 *)__x86_indirect_thunk_edx - (ip + 5));
> @@ -1280,7 +1279,7 @@ static int emit_jmp_edx(u8 **pprog, u8 *ip)
>  #endif
>         *pprog = prog;
>
> -       return cnt;
> +       return 0;
>  }
>
>  /*
> --
> 2.25.1
>