Re: [PATCH] ASoC: codecs: Fix WCD_MBHC_HPH_PA_EN usage

From: Dan Carpenter
Date: Wed Nov 03 2021 - 06:52:18 EST


On Tue, Oct 19, 2021 at 07:39:04PM +0200, Christophe JAILLET wrote:
> Le 19/10/2021 à 15:47, Srinivas Kandagatla a écrit :
> >
> >
> > On 17/10/2021 08:31, Christophe JAILLET wrote:
> > > 'hphpa_on' is known to be false, so the if block at the end of the
> > > function
> > > is dead code.
> >
> > Yes, this is a dead code we should remove it.
>
> Ok, thanks for the clarification.
>
> >
> > This code was part of moisture detection logic which is not enabled in
> > upstream code yet.
>
> If 'yet' is the important word of the sentence, maybe the best is to leave
> the code as-is.
> If you prefer it to be removed, I can send a patch if it helps.

Just delete the dead code... Never try to plan for the future, it's too
unpredictable.

regards,
dasn carpenter