Re: [PATCH 0/4] Fix kcontrol put callback in Tegra drivers

From: Sameer Pujar
Date: Wed Nov 03 2021 - 07:29:26 EST




On 11/3/2021 2:20 PM, Jaroslav Kysela wrote:
External email: Use caution opening links or attachments


On 03. 11. 21 6:04, Sameer Pujar wrote:
This series fixes kcontrol put callback in some of the Tegra drivers
which are used on platforms based on Tegra210 and later. The callback
is expected to return 1 whenever the HW update is done.

The logic is a little bit another. The 1 means change, so you should compare
the register / cached value and return 1 only when a different value is set.
Your implementation invokes the change events for duplicate updates.

Sorry, I did not think the about duplicate updates. Thanks for the suggestion.