Re: [PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem
From: Neal Gompa
Date: Wed Nov 03 2021 - 08:35:01 EST
On Wed, Nov 3, 2021 at 8:32 AM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
>
> Hi
>
> Am 03.11.21 um 12:05 schrieb Neal Gompa:
> > On Wed, Nov 3, 2021 at 6:48 AM Javier Martinez Canillas
> > <javierm@xxxxxxxxxx> wrote:
> >>
> >> The "nomodeset" kernel cmdline parameter is handled by the vgacon driver
> >> but the exported vgacon_text_force() symbol is only used by DRM drivers.
> >>
> >> It makes much more sense for the parameter logic to be in the subsystem
> >> of the drivers that are making use of it. Let's move that to DRM.
> >>
> >> Suggested-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> >> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> >> ---
> >
> > Please no, I'd much rather have a better, more meaningful option
> > instead of "nomodeset". If anything, I would like this option to
> > eventually do nothing and replace it with a better named option that's
> > namespaced by drm on the command-line. That was part of the feedback I
> > gave in the original patch set, and I still stand by that.
>
> This was nack'ed for now during irc chats with others. There was no
> clear semantics for the new parameter and nomodeset is good enough for
> now. I agree that nomodeset is badly named, though.
>
Where are these chats happening? I'm mostly talking to Javier in the
#devel:fedoraproject.org Matrix room, so I don't know about anything
else...
--
真実はいつも一つ!/ Always, there's only one truth!