Re: [PATCH v2 03/12] x86/sev: Save and print negotiated GHCB protocol version

From: Borislav Petkov
Date: Wed Nov 03 2021 - 10:27:31 EST


On Mon, Sep 13, 2021 at 05:55:54PM +0200, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@xxxxxxx>
>
> Save the results of the GHCB protocol negotiation into a data structure
> and print information about versions supported and used to the kernel
> log.

Which is useful for?

> +/*
> + * struct sev_ghcb_protocol_info - Used to return GHCB protocol
> + * negotiation details.
> + *
> + * @hv_proto_min: Minimum GHCB protocol version supported by Hypervisor
> + * @hv_proto_max: Maximum GHCB protocol version supported by Hypervisor
> + * @vm_proto: Protocol version the VM (this kernel) will use
> + */
> +struct sev_ghcb_protocol_info {

Too long a name - ghcb_info is perfectly fine.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette