Re: [PATCH] clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning
From: Krzysztof Kozlowski
Date: Wed Nov 03 2021 - 12:49:40 EST
On 03/11/2021 17:48, Will Deacon wrote:
> Commit ae460fd9164b ("clocksource/drivers/exynos_mct: Prioritise Arm
> arch timer on arm64") changed the rating of the MCT clockevents device
> to be lower than the Arm architected timer and, in the process, replaced
> a semicolon with a comma thanks to a silly copy-paste error.
>
> Put the semicolon back so that the code looks more idiomatic and resolve
> the SUSPECT_COMMA_SEMICOLON warning from checkpatch at the same time.
>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Signed-off-by: Will Deacon <will@xxxxxxxxxx>
> ---
>
> Although this doesn't have a functional impact and I'd normally not pay
> too much attention to checkpatch warnings, the code is pretty weird as-is
> and I didn't intend for that comma to be there!
>
> drivers/clocksource/exynos_mct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
Best regards,
Krzysztof