Re: [RESEND PATCH v2] string: uninline memcpy_and_pad

From: Linus Torvalds
Date: Wed Nov 03 2021 - 14:34:28 EST


On Wed, Nov 3, 2021 at 11:03 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> Either case, I'll wait for advice from Linus on how to proceed.

It's a completely unimportant function, used in a couple of places,
not performance-sensitive, not security-sensitive, and not worth any
kind of buffer size checking.

And it's breaking the build because being inline somehow confuses the compiler.

It gets out-of-lined.

Kees - once you have gotten all compilers fixed and everybody using
them, you can send a patch to make it inline again.

I estimate that is in about ten years or so.

Linus