Re: [PATCH] tcp: Use BIT() for OPTION_* constants

From: Eric Dumazet
Date: Wed Nov 03 2021 - 18:50:08 EST




On 11/3/21 3:17 PM, Leonard Crestez wrote:
> Extending these flags using the existing (1 << x) pattern triggers
> complaints from checkpatch. Instead of ignoring checkpatch modify the
> existing values to use BIT(x) style in a separate commit.
>
> Signed-off-by: Leonard Crestez <cdleonard@xxxxxxxxx>
>

Yes, I guess checkpatch does not know that we currently use at most 16 bits :)

u16 options = opts->options;

Anyway, this seems fine.

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>