Re: [PATCH net v2] net: marvell: prestera: fix hw structure laid out

[Volodymyr Mytnyk [C]]

> On Wed, Nov 3, 2021 at 10:56 AM Volodymyr Mytnyk
> <volodymyr.mytnyk@xxxxxxxxxxx> wrote:
> > From: Volodymyr Mytnyk <vmytnyk@xxxxxxxxxxx>
> >
> > - fix structure laid out discussed in:
> >     [PATCH net-next v4] net: marvell: prestera: add firmware v4.0 support
> >     https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_kernel_msg4127689.html&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=Y41pILcavAE6E85lMlyXdQBpY03LUi5-euLmDcLBBRw&m=MggFlhvEsV0dikgTUWWhK5i05HFJvv2BF0EdMIAghqSI92og-BAfZXe2Wm82FjG7&s=KkA8BuuYlG-6UWpaKKvGkvVRbhyoKnSNnftLBCYELDE&e= 
> >
> > - fix review comments discussed in:
> >     [PATCH] [-next] net: marvell: prestera: Add explicit padding
> >     https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_kernel_msg4130293.html&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=Y41pILcavAE6E85lMlyXdQBpY03LUi5-euLmDcLBBRw&m=MggFlhvEsV0dikgTUWWhK5i05HFJvv2BF0EdMIAghqSI92og-BAfZXe2Wm82FjG7&s=Hs1u5qLhVlePG9KiNdOJiDpLTF200_9hn0gL9WLRJUA&e= 
> >
> > - fix patchwork issues
> > - rebase on net master
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Fixes: bb5dbf2cc64d ("net: marvell: prestera: add firmware v4.0 support")
> > Signed-off-by: Volodymyr Mytnyk <vmytnyk@xxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/drivers/net/ethernet/marvell/prestera/prestera_hw.c
> > +++ b/drivers/net/ethernet/marvell/prestera/prestera_hw.c
> 
> >  struct prestera_msg_port_flood_param {
> >         u8 type;
> >         u8 enable;
> > -};
> > +       u8 __pad[2];
> > +} __packed;
> 
> What's the point of having __packed on a struct of bytes?

This one can be removed probaby. Thanks. Will fix it in follow up patch set.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 

              Volodymyr