Re: [PATCH v2 1/8] staging: vt6655: Introduce `idx` temporary variable
From: Dan Carpenter
Date: Thu Nov 04 2021 - 08:09:39 EST
On Mon, Nov 01, 2021 at 02:31:59PM +0000, Karolina Drobnik wrote:
> Add a local variable to store `MISCFIFO_SYNDATA_IDX` offset.
> This change helps in shortening the lines in `rf.c` that
> are deemed too long by checkpatch.pl.
>
I started reviewing the v1 patch but I should have been reviewing this
patchset. Please don't do this. Leave the constant as a constant so
we don't have to look it up.
regards,
dan carpenter