[PATCH v19 0/5] Add tpm i2c ptp driver
From: amirmizi6
Date: Thu Nov 04 2021 - 10:05:19 EST
From: Amir Mizinski <amirmizi6@xxxxxxxxx>
This patch set adds support for TPM devices that implement the I2C.
Interface defined by TCG PTP specification:
https://trustedcomputinggroup.org/wp-content/uploads/TCG_PC_Client_Platform_TPM_Profile_PTP_2.0_r1.03_v22.pdf
The driver was tested on Raspberry-Pie 3, using Nuvoton NPCT75X TPM.
Interrupts are not implemented yet, preparing it for the next patch.
This patch is based on initial work by oshri Alkoby, Alexander Steffen and Christophe Ricard
Changes since version 1:
-"char:tpm:Add check_data handle to tpm_tis_phy_ops in order to check data integrity"
- Fixed and extended commit description.
- Fixed an issue regarding handling max retries.
-"dt-bindings: tpm: Add YAML schema for TPM TIS I2C options":
-Converted "tpm_tis_i2c.txt" to "tpm-tis-i2c.yaml".
- Renamed "tpm_tis-i2c" to "tpm-tis-i2c".
- Removed interrupts properties.
-"char: tpm: add tpm_tis_i2c driver"
- Replaced "tpm_tis-i2c" with "tpm-tis-i2c" in "tpm_tis_i2c.c".
Addressed comments from:
- Jarkko Sakkinen: https://patchwork.kernel.org/patch/11236257/
- Rob Herring: https://patchwork.kernel.org/patch/11236253/
Changes since version 2:
- Added 2 new commits with improvements suggested by Benoit Houyere.
-"Fix expected bit handling and send all bytes in one shot without last byte in exception"
-"Handle an exception for TPM Firmware Update mode."
- Updated patch to latest v5.5
-"dt-bindings: tpm: Add YAML schema for TPM TIS I2C options"
- Added "interrupts" and "crc-checksum" to properties.
- Updated binding description and commit info.
-"char: tpm: add tpm_tis_i2c driver" (suggested by Benoit Houyere)
- Added repeat I2C frame after NACK.
- Checksum I2C feature activation in DTS file configuration.
Addressed comments from:
- Rob Herring: https://lore.kernel.org/patchwork/patch/1161287/
Changes since version 3:
- Updated patch to latest v5.6
- Updated commits headlines and development credit format by Jarkko Sakkinen suggestion
-"tpm: tpm_tis: Make implementation of read16 read32 write32 optional"
- Updated commit description.
-"dt-bindings: tpm: Add YAML schema for TPM TIS I2C options"
- Fixed 'make dt_binding_check' errors on YAML file.
- Removed interrupts from required and examples since there is no use for them in current patch.
Addressed comments from:
- Jarkko Sakkinen: https://lore.kernel.org/patchwork/patch/1192101/
- Rob Herring: https://lore.kernel.org/patchwork/patch/1192099/
Changes since version 4:
-"tpm: tpm_tis: Make implementation of read16 read32 write32 optional"
-Added a "Reviewed-by" tag:
-"tpm: tpm_tis: Add check_data handle to tpm_tis_phy_ops in order to check data integrity"
-Fixed credit typos.
-"tpm: tpm_tis: rewrite "tpm_tis_req_canceled()""
-Added fixes tag and removed changes for STM.
-"tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception"
-Fixed typos, edited description to be clearer, and added a "Suggested-by" tag.
-"tpm: Handle an exception for TPM Firmware Update mode."
-Added a "Suggested-by" tag.
-"dt-bindings: tpm: Add YAML schema for TPM TIS I2C options"
-Fixed 'make dt_binding_check' errors.
-"tpm: tpm_tis: add tpm_tis_i2c driver"
-Added tested-by tag by Eddie James.
-Fixed indent in Kconfig file.
-Fixed 'MODULE_DESCRIPTION'.
Addressed comments from:
- Jarkko Sakkinen: https://patchwork.kernel.org/patch/11467645/
https://patchwork.kernel.org/patch/11467655/
https://patchwork.kernel.org/patch/11467643/
https://patchwork.kernel.org/patch/11467659/
https://patchwork.kernel.org/patch/11467651/
- Rob Herring: https://patchwork.kernel.org/patch/11467653/
- Randy Dunlap: https://patchwork.kernel.org/patch/11467651/
- Eddie James: https://lore.kernel.org/patchwork/patch/1192104/
Changes since version 5:
-"tpm: tpm_tis: Add check_data handle to tpm_tis_phy_ops"
-Updated short description and fixed long description to be more clear.
Addressed comments from:
- Jarkko Sakkinen: https://lkml.org/lkml/2020/4/6/748
Changes since version 6:
-"tpm: tpm_tis: Make implementation of read16, read32 and write32 optional"
-Fixed short description.
-fixed long description proofreading issues.
-"tpm: tpm_tis: Add check_data handle to tpm_tis_phy_ops"
-Fixed long description by Jarkko comments and proofreading issues.
-Replaced "check_data" with verify_data_integrity".
-New line before return statement.
-"tpm: tpm_tis: rewrite "tpm_tis_req_canceled()"
-Fixed line over 80 characters.
-fixed long description proofreading issues.
-" tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot"
-fixed long description proofreading issues.
-"dt-bindings: tpm: Add YAML schema for TPM TIS I2C option"
-Replaced "tpm-tis-i2c@2e" with "tpm_tis@2e".
-Fixed CRC_Checksum description.
-"tpm: tpm_tis: add tpm_tis_i2c driver"
-Replaced "depends on CRC_CCIT" with "select CRC_CCIT".
-Added tested-by tag by Joel Stanley.
-Fixed checkpatch.pl warnings.
Addressed comments from:
- Jarkko Sakkinen:
https://lore.kernel.org/patchwork/patch/1221336/
https://lore.kernel.org/patchwork/patch/1221337/
https://lore.kernel.org/patchwork/patch/1221339/
- Joel Stanley:
https://lore.kernel.org/patchwork/patch/1220543/
- Rob Herring:
https://lore.kernel.org/patchwork/patch/1221334/
Changes since version 7:
- Added a new commit with improvements suggested by Benoit Houyere.
-"tpm: tpm_tis: verify TPM_STS register is valid after locality request"
-"tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()""
-Fixed Hash for Fixes tag.
-"tpm: Add YAML schema for TPM TIS I2C options"
-Added a compatible string specific to the nuvoton npct75x chip.
-"tpm: tpm_tis: add tpm_tis_i2c driver"
-added a compatible string according to yaml file.
Addressed comments from:
- Jarkko Sakkinen:
https://lore.kernel.org/patchwork/patch/1231524/
- Rob Herring:
https://lore.kernel.org/patchwork/patch/1231526/
Changes since version 8:
- "tpm: tpm_tis: Make implementation of read16, read32 and write32 optional"
-Fixed a compile error conflicting CR50
- "tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception"
-Moved commit backwards from 4/8 to 2/8 for a better flow with new data integrity check design
- "tpm: tpm_tis: Add retry in case of protocol failure or data integrity (on I2C only) failure."
-Renamed from "tpm: tpm_tis: Add check_data handle to tpm_tis_phy_ops"
-Redesign and added a retry for additional error cases.
- "tpm: Add YAML schema for TPM TIS I2C options"
-Fixed Dual-license new binding
-Removed "oneOf"
-Fixed tpm_tis@2e to tpm@2e
Addressed comments from:
- Jarkko Sakkinen:
https://lore.kernel.org/patchwork/patch/1240728/
https://lore.kernel.org/patchwork/patch/1240736/
- Rob Herring:
https://lore.kernel.org/patchwork/patch/1240733/
Changes since version 9:
- "tpm: Make read{16, 32}() and write32() in tpm_tis_phy_ops optional"
-Fixed short description
- "tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception"
-Canceled wait_for_tpm_stat() function renaming.
-Fixed long description
- "tpm: Add YAML schema for TPM TIS I2C options"
-Added a reviewed-by tag.
Addressed comments from:
- Jarkko Sakkinen:
https://lore.kernel.org/patchwork/patch/1247163/
https://lore.kernel.org/patchwork/patch/1247164/
- Rob Herring:
https://lore.kernel.org/patchwork/patch/1247161/
Changes since version 10:
- "tpm: Make read{16, 32}() and write32() in tpm_tis_phy_ops optional"
-Added a Reviewed-by and Tested-by tags
- "tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception"
-Renamed "mask_result" parameter with "stat"
- "tpm: tpm_tis: Add retry in case of protocol failure or data integrity (on I2C only) failure."
-Edited long description.
-Modified tpm_tis_recv() to __tpm_tis_recv() and Introduced a new tpm_tis_recv() function
Addressed comments from:
- Jarkko Sakkinen:
https://lore.kernel.org/patchwork/patch/1252428/
https://lore.kernel.org/patchwork/patch/1252422/
https://lore.kernel.org/patchwork/patch/1252424/
Changes since version 11:
- "tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception"
-Added a "Reviewed-by" tag
-Renamed 'wait_for_tpm_stat()' function with 'tpm_tis_wait_for_stat()'
- "tpm: tpm_tis: Add retry in case of protocol failure."
-Removed data integrity check and created a new commit for it.
-Edited short and long description.
- "tpm: tpm_tis: Add verify_data_integrity handle to tpm_tis_phy_ops"
-This is a new commit.
Addressed comments from:
- Jarkko Sakkinen:
https://lore.kernel.org/patchwork/patch/1258107/
https://lore.kernel.org/patchwork/patch/1258110/
Changes since version 12:
- Moved "tpm: Add YAML schema for TPM TIS I2C options" to end of patch.
- Removed two commits to be resubmited on later patch:
- "tpm: tpm_tis: Add retry in case of protocol failure."
- "tpm: tpm_tis: Add verify_data_integrity handle to tpm_tis_phy_ops"
- "tpm: tpm_tis: add tpm_tis_i2c driver"
- Removed verify data integrity (Checksum) functuality from i2c driver.
- Edited Long Description.
- Updated header comment for tpm_tis_i2c.c
Addressed comments from:
- Jarkko Sakkinen:
https://lore.kernel.org/patchwork/patch/1263805/
https://lore.kernel.org/patchwork/patch/1263813/
Changes since version 13:
- Edited description of commits 1-6 by Jarkko comments.
- "tpm: Add YAML schema for TPM TIS I2C options"
- Fixed YAML compilation error of missing "additionalProperties" field
Addressed comments from:
- Jarkko Sakkinen:
https://lkml.org/lkml/2021/8/26/546
https://lkml.org/lkml/2021/8/26/548
https://lkml.org/lkml/2021/8/26/550
https://lkml.org/lkml/2021/8/26/551
https://lkml.org/lkml/2021/8/26/552
https://lkml.org/lkml/2021/8/26/553
https://lkml.org/lkml/2021/8/26/555
- Rob Herring:
https://lkml.org/lkml/2021/8/26/427
Changes since version 14:
- "tpm: Make read{16, 32}() and write32() in tpm_tis_phy_ops optional"
-Removed commit.
- "tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception"
-Fixed description and restored "wait_for_tom_stat" to its original name
- "tpm: tpm_tis: add tpm_tis_i2c driver"
-Added read{16, 32}() and write32() functions in i2c driver.
Addressed comments from:
- Jarkko Sakkinen:
https://lkml.org/lkml/2021/9/13/2235
https://lkml.org/lkml/2021/9/13/2241
Changes since version 15:
- tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception
-Fixed and added description
-Added a fixed tag
-Changed stat parameter name to result.
- tpm: Add YAML schema for TPM TIS I2C options
-Added Reviewd-by tag
Addressed comments from:
- Jarkko Sakkinen:
https://www.spinics.net/lists/linux-integrity/msg19686.html
- Rob Herring:
https://www.spinics.net/lists/linux-integrity/msg19686.html
Changes since version 16:
- tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception
-removed modifing of handeling the last byte on send command for future addition.
-fixed minor description issues and fixes tag format.
-tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()"
-fixed fixes tag format.
Addressed comments from:
- Jarkko Sakkinen:
https://www.spinics.net/lists/kernel/msg4120640.html
https://www.spinics.net/lists/kernel/msg4120641.html
Changes since version 17:
- tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception
-removed "fixed" tag
-renamed wait_for_tpm_stat(): tpm_tis_wait_for_stat()
-renamed result parameter : expected
-fixed description for above changes.
- tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()"
-removed "fixed" tag
- tpm: tpm_tis: Verify TPM_STS register is valid after locality request
-rewrote first peregraph of long description to explain issue
- tpm: tpm_tis: Add tpm_tis_i2c driver
-drop one space from Kconfig help
Addressed comments from:
- Jarkko Sakkinen:
https://lkml.org/lkml/2021/10/25/1848
https://lkml.org/lkml/2021/10/25/1849
https://lkml.org/lkml/2021/10/25/1850
- Randy Dunlap
https://lkml.org/lkml/2021/10/24/233
Changes since version 18:
- Removed "tpm: Handle an exception for TPM Firmware Update mode" commit from patch since it is being handled in anoither patch by Borys Movcha.
- tpm_tis: Fix expected bit handling
-Added Reviewd-by tag
- tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()"
-Removed outer parentheses in final return condition and put it to a single line.
- tpm: tpm_tis: Verify TPM_STS register is valid after locality request
-Fix tpm_tis_wait_for_stat() call
- tpm: tpm_tis: Add tpm_tis_i2c driver
-fix code review comments along the driver by Jarkko
Addressed comments from:
- Jarkko Sakkinen:
https://lkml.org/lkml/2021/11/2/978
https://lkml.org/lkml/2021/11/2/987
https://lkml.org/lkml/2021/11/2/989
https://lkml.org/lkml/2021/11/2/993
Amir Mizinski (5):
tpm_tis: Fix expected bit handling
tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()"
tpm: tpm_tis: Verify TPM_STS register is valid after locality request
tpm: tpm_tis: Add tpm_tis_i2c driver
tpm: Add YAML schema for TPM TIS I2C options
.../bindings/security/tpm/tpm-tis-i2c.yaml | 52 ++++
drivers/char/tpm/Kconfig | 12 +
drivers/char/tpm/Makefile | 1 +
drivers/char/tpm/tpm_tis_core.c | 72 +++---
drivers/char/tpm/tpm_tis_i2c.c | 263 +++++++++++++++++++++
5 files changed, 361 insertions(+), 39 deletions(-)
create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
create mode 100644 drivers/char/tpm/tpm_tis_i2c.c
--
2.7.4