Re: [RFC PATCH v2 0/5] Add hardware prefetch driver for A64FX and Intel processors

[Borislav Petkov]

On Thu, Nov 04, 2021 at 02:21:17PM +0900, Kohei Tarumizu wrote:
> This patch series add hardware prefetch driver register/unregister
> function. The purpose of this driver is to provide an interface to
> control the hardware prefetch mechanism depending on the application
> characteristics.

This is all fine and dandy but what I'm missing in this pile of text -
at least I couldn't find it - is why do we need this in the upstream
kernel?

Is there some real-life use case that would benefit from software
fiddling with prefetchers or is this one of those, well, we have those
controls, lets expose them in the OS?

IOW, you need to sell this stuff properly first - then talk design.

>  create mode 100644 drivers/hwpf/Kconfig
>  create mode 100644 drivers/hwpf/Makefile
>  create mode 100644 drivers/hwpf/fujitsu_hwpf.c
>  create mode 100644 drivers/hwpf/hwpf.c
>  create mode 100644 drivers/hwpf/intel_hwpf.c
>  create mode 100644 include/linux/hwpf.h

I'm not sure about a wholly separate drivers/hwpf/ - it's not like there
are gazillion different hw prefetch drivers.

HTH.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette