Re: [PATCH] block: fix bd_holder_dir kobject_create_and_add() error handling

From: Jens Axboe
Date: Thu Nov 04 2021 - 15:30:35 EST


On 11/4/21 1:29 PM, Luis Chamberlain wrote:
> Commit 83cbce957446 ("block: add error handling for device_add_disk /
> add_disk") added error handling to device_add_disk(), however the goto
> label for the bd_holder_dir kobject_create_and_add() failure did not set
> the return value correctly, and so we can end up in a situation where
> kobject_create_and_add() fails but we report success.

I'm just going to fold this one in, as it's top-of-tree.

--
Jens Axboe