Re: perf build broken looking for bpf/{libbpf,bpf}.h after merge with upstream

From: Arnaldo Carvalho de Melo
Date: Thu Nov 04 2021 - 16:42:44 EST


Em Thu, Nov 04, 2021 at 01:33:20PM -0700, Namhyung Kim escreveu:
> On Thu, Nov 4, 2021 at 11:13 AM Song Liu <songliubraving@xxxxxx> wrote:
> > > On Nov 4, 2021, at 11:11 AM, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> > > Em Thu, Nov 04, 2021 at 10:56:26AM -0700, Andrii Nakryiko escreveu:
> > >> On the side note, why BUILD_BPF_SKEL=1 is not a default, we might have
> > >> caught this sooner. Is there any reason not to flip the default?

> > > I asked Song in the past about this, and asked again on another reply to
> > > this thread, I think it should be the default.

> > > Song, Namhyung? You're the skel guys (so far) :-)

> > Yeah, let's make it default.

> Then it'd require 'clang' for the perf build. Maybe we can check
> the availability of the compiler and disable it back if not.

Right, an extra feature check.

- Arnaldo