RE: [PATCH] ACPI: Add AEST in ACPI Table Definitions

From: ishii.shuuichir@xxxxxxxxxxx
Date: Thu Nov 04 2021 - 19:29:37 EST


Hi, Rafael.

Thank you for your comments.
We will respond as you suggested.

Best regards,
Shuuichirou.

> -----Original Message-----
> From: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Sent: Thursday, November 4, 2021 8:31 PM
> To: Ishii, Shuuichirou/石井 周一郎 <ishii.shuuichir@xxxxxxxxxxx>
> Cc: rjw@xxxxxxxxxxxxx; lenb@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; robert.moore@xxxxxxxxx;
> rafael.j.wysocki@xxxxxxxxx; devel@xxxxxxxxxx; lorenzo.pieralisi@xxxxxxx;
> guohanjun@xxxxxxxxxx; sudeep.holla@xxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] ACPI: Add AEST in ACPI Table Definitions
>
> On Thu, Nov 4, 2021 at 8:14 AM ishii.shuuichir@xxxxxxxxxxx
> <ishii.shuuichir@xxxxxxxxxxx> wrote:
> >
> > ping?
> >
> > P.S.
> > We should have added the maintainer of ACPI FOR ARM64 (ACPI/arm64)
> > first, but since AEST is an arm-spec ACPI table, added the concerned
> > persons as new e-mail addresses.
>
> Please resend the patch, then, with all of the requisite addresses present in the
> CC list.
>
> > > -----Original Message-----
> > > From: Shuuichirou Ishii <ishii.shuuichir@xxxxxxxxxxx>
> > > Sent: Tuesday, October 26, 2021 4:53 PM
> > > To: rjw@xxxxxxxxxxxxx; lenb@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx;
> > > linux-kernel@xxxxxxxxxxxxxxx; robert.moore@xxxxxxxxx;
> > > erik.kaneda@xxxxxxxxx; rafael.j.wysocki@xxxxxxxxx; devel@xxxxxxxxxx
> > > Cc: Ishii, Shuuichirou/石井 周一郎 <ishii.shuuichir@xxxxxxxxxxx>
> > > Subject: [PATCH] ACPI: Add AEST in ACPI Table Definitions
> > >
> > > When We added AEST using the Upgrading ACPI tables via initrd
> > > function, the kernel could not recognize the AEST, so We added AEST the
> ACPI table definition.
> > >
> > > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@xxxxxxxxxxx>
> > > ---
> > > drivers/acpi/tables.c | 2 +-
> > > include/acpi/actbl2.h | 1 +
> > > 2 files changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index
> > > f9383736fa0f..ab0fb4c33e07 100644
> > > --- a/drivers/acpi/tables.c
> > > +++ b/drivers/acpi/tables.c
> > > @@ -499,7 +499,7 @@ static const char
> > > table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
> > > ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT,
> ACPI_SIG_FADT,
> > > ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> > > ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> > > - ACPI_SIG_NHLT };
> > > + ACPI_SIG_NHLT, ACPI_SIG_AEST };
> > >
> > > #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
> > >
> > > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h index
> > > a47b32a5cbde..b586e40d4b86 100644
> > > --- a/include/acpi/actbl2.h
> > > +++ b/include/acpi/actbl2.h
> > > @@ -48,6 +48,7 @@
> > > #define ACPI_SIG_SDEV "SDEV" /* Secure Devices table
> */
> > > #define ACPI_SIG_NHLT "NHLT" /* Non-HDAudio Link
> Table
> > > */
> > > #define ACPI_SIG_SVKL "SVKL" /* Storage Volume Key
> > > Location Table */
> > > +#define ACPI_SIG_AEST "AEST" /* Arm Error Source Table */
> > >
> > > /*
> > > * All tables must be byte-packed to match the ACPI specification,
> > > since
> > > --
> > > 2.27.0
> >