Re: [PATCH] powerpc: xmon: remove the duplicated operand of the bitwise operator

From: Michael Ellerman
Date: Fri Nov 05 2021 - 02:13:52 EST


cgel.zte@xxxxxxxxx writes:
> From: Ye Guojin <ye.guojin@xxxxxxxxxx>
>
> The operands of the bitwise OR operator are duplicated, remove one of
> them.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Ye Guojin <ye.guojin@xxxxxxxxxx>
> ---
> arch/powerpc/xmon/ppc-opc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, but this code is copied from binutils, we don't take cleanup
patches to it.

cheers

> diff --git a/arch/powerpc/xmon/ppc-opc.c b/arch/powerpc/xmon/ppc-opc.c
> index dfb80810b16c..2cab0ec0d162 100644
> --- a/arch/powerpc/xmon/ppc-opc.c
> +++ b/arch/powerpc/xmon/ppc-opc.c
> @@ -6731,9 +6731,9 @@ const struct powerpc_opcode powerpc_opcodes[] = {
> {"fre.", A(63,24,1), AFRALFRC_MASK, POWER5, POWER7|PPCVLE, {FRT, FRB, A_L}},
>
> {"fmul", A(63,25,0), AFRB_MASK, PPCCOM, PPCEFS|PPCVLE, {FRT, FRA, FRC}},
> -{"fm", A(63,25,0), AFRB_MASK, PWRCOM, PPCVLE|PPCVLE, {FRT, FRA, FRC}},
> +{"fm", A(63, 25, 0), AFRB_MASK, PWRCOM, PPCVLE, {FRT, FRA, FRC}},
> {"fmul.", A(63,25,1), AFRB_MASK, PPCCOM, PPCEFS|PPCVLE, {FRT, FRA, FRC}},
> -{"fm.", A(63,25,1), AFRB_MASK, PWRCOM, PPCVLE|PPCVLE, {FRT, FRA, FRC}},
> +{"fm.", A(63, 25, 1), AFRB_MASK, PWRCOM, PPCVLE, {FRT, FRA, FRC}},
>
> {"frsqrte", A(63,26,0), AFRAFRC_MASK, POWER7, PPCVLE, {FRT, FRB}},
> {"frsqrte", A(63,26,0), AFRALFRC_MASK, PPC, POWER7|PPCVLE, {FRT, FRB, A_L}},
> --
> 2.25.1