[PATCH v2] driver core: platform: Make use of the helper function dev_err_probe()
From: Cai Huoqing
Date: Fri Nov 05 2021 - 03:15:29 EST
When possible using dev_err_probe() helps to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
---
v1->v2: *Revert the change of variable name 'dev'.
drivers/base/platform.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 598acf93a360..7109351366c8 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -258,8 +258,9 @@ int platform_get_irq(struct platform_device *dev, unsigned int num)
int ret;
ret = platform_get_irq_optional(dev, num);
- if (ret < 0 && ret != -EPROBE_DEFER)
- dev_err(&dev->dev, "IRQ index %u not found\n", num);
+ if (ret < 0)
+ return dev_err_probe(&dev->dev, ret,
+ "IRQ index %u not found\n", num);
return ret;
}
--
2.25.1