Re:Re: [PATCH v2] bus: mhi: pci_generic: Add new device ID support for T99W175

[Slark Xiao]

At 2021-11-02 11:56:32, "Manivannan Sadhasivam" <mani@xxxxxxxxxx> wrote:
>On Fri, Oct 29, 2021 at 06:49:18PM +0800, Slark Xiao wrote:
>> Add new device ID 0xe0bf for T99W175.
>> This device ID is created because it is using Qualcomm SDX55 new base line.
>> 
>> Test evidence as below:
>> root@jbd-ThinkPad-P1-Gen-4:/dev# lspci -nn | grep Foxconn
>> 0000:08:00.0 Wireless controller [0d40]: Foxconn International, Inc. Device [105b:e0bf]
>> root@jbd-ThinkPad-P1-Gen-4:/dev# cat wwan0at0 & echo -ne "ati\r" > wwan0at0
>> [2] 2977
>> root@jbd-ThinkPad-P1-Gen-4:/dev# ati
>> Manufacturer: Qualcomm
>> Model: T99W175
>> Revision: T99W175.F0.6.0.0.6.CC.005  1  [Oct 21 2021 10:00:00]
>> IMEI:
>> +GCAP: +CGSM
>> 
>> OK
>> 
>> Signed-off-by: Slark Xiao <slark_xiao@xxxxxxx>
>
>Reviewed-by: Manivannan Sadhasivam <mani@xxxxxxxxxx>
>
>Thanks,
>Mani
>
Hi Mani,
    What's our next step? I didn't see any reject or confirm email.
   Could you help apply it if there is no concern?

Thanks
Slark
>> ---
>> 
>> v2: Add descriptions about the dfiiference between 0xe0ab and 0xeobf.
>> ---
>>  drivers/bus/mhi/pci_generic.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
>> index 59a4896a8030..94d8aa9c2eae 100644
>> --- a/drivers/bus/mhi/pci_generic.c
>> +++ b/drivers/bus/mhi/pci_generic.c
>> @@ -423,6 +423,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>>  	/* DW5930e (sdx55), Non-eSIM, It's also T99W175 */
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0b1),
>>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>> +	/* T99W175 (sdx55), Based on Qualcomm new baseline */
>> +	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0bf),
>> +		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>>  	/* MV31-W (Cinterion) */
>>  	{ PCI_DEVICE(0x1269, 0x00b3),
>>  		.driver_data = (kernel_ulong_t) &mhi_mv31_info },
>> -- 
>> 2.25.1
>>