RE: [PATCH v2] um: use swap() to make code cleaner

From: David Laight
Date: Fri Nov 05 2021 - 07:30:46 EST


From: Yang Guang
> Sent: 05 November 2021 06:19
>
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.

Is there any real point to any of these patches??

If I'm reading a 'random' piece of code I now have to assume
that swap() is something that 'magically' exchanges two items.
This requires more brain-power than parsing the three lines
that do an actual swap.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)