Re: [PATCH 7/7] net: dsa: b53: Expose PTP timestamping ioctls to userspace

[Martin Kaistra]

Am 04.11.21 um 18:42 schrieb Richard Cochran:
> On Thu, Nov 04, 2021 at 02:32:01PM +0100, Martin Kaistra wrote:
> > +static int b53_set_hwtstamp_config(struct b53_device *dev, int port,
> > +				   struct hwtstamp_config *config)
> > +{
> > +	struct b53_port_hwtstamp *ps = &dev->ports[port].port_hwtstamp;
> > +	bool tstamp_enable = false;
> > +
> > +	clear_bit_unlock(B53_HWTSTAMP_ENABLED, &ps->state);
> > +
> > +	/* Reserved for future extensions */
> > +	if (config->flags)
> > +		return -EINVAL;
> > +
> > +	switch (config->tx_type) {
> > +	case HWTSTAMP_TX_ON:
> > +		tstamp_enable = true;
> > +		break;
> > +	case HWTSTAMP_TX_OFF:
> > +		tstamp_enable = false;
> > +		break;
> > +	default:
> > +		return -ERANGE;
> > +	}
> > +
> > +	switch (config->rx_filter) {
> > +	case HWTSTAMP_FILTER_NONE:
> > +		tstamp_enable = false;
> > +		break;
> > +	case HWTSTAMP_FILTER_PTP_V2_L2_EVENT:
> > +	case HWTSTAMP_FILTER_PTP_V2_L2_SYNC:
> > +	case HWTSTAMP_FILTER_PTP_V2_L2_DELAY_REQ:
> > +	case HWTSTAMP_FILTER_PTP_V2_EVENT:
> > +	case HWTSTAMP_FILTER_PTP_V2_SYNC:
> > +	case HWTSTAMP_FILTER_PTP_V2_DELAY_REQ:
>
> This is incorrect.  HWTSTAMP_FILTER_PTP_V2_EVENT includes support for
> UDP/IPv4 and UDP/IPv6.  Driver should return error here.

Ok, then I will remove HWTSTAMP_FILTER_PTP_V2_(EVENT|SYNC|DELAY_REQ) 
from this list, what about HWTSTAMP_FILTER_ALL?

> > +	case HWTSTAMP_FILTER_ALL:
> > +		config->rx_filter = HWTSTAMP_FILTER_PTP_V2_L2_EVENT;
> > +		break;
> > +	default:
> > +		return -ERANGE;
> > +	}
>
> Thanks,
> Richard