Re: [PATCH 2/2] kobject: wait until kobject is cleaned up before freeing module

[kernel test robot]

Hi Ming,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on v5.15 next-20211105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ming-Lei/kobject-avoid-to-cleanup-kobject-after-module-is-unloaded/20211105-144026
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 27e0bcd02990f7291adb0f111e300f06c495d509
config: mips-buildonly-randconfig-r003-20211105 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4a9e015dd3d3e39d5723ea46579ba21f5394806a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ming-Lei/kobject-avoid-to-cleanup-kobject-after-module-is-unloaded/20211105-144026
        git checkout 4a9e015dd3d3e39d5723ea46579ba21f5394806a
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   lib/kobject.c: In function 'kobj_module_callback':
>> lib/kobject.c:741:20: error: 'MODULE_STATE_GOING' undeclared (first use in this function)
     741 |         if (val != MODULE_STATE_GOING)
         |                    ^~~~~~~~~~~~~~~~~~
   lib/kobject.c:741:20: note: each undeclared identifier is reported only once for each function it appears in


vim +/MODULE_STATE_GOING +741 lib/kobject.c

   730	
   731	#ifdef CONFIG_DEBUG_KOBJECT_RELEASE
   732	/*
   733	 * Module notifier call back, flushing scheduled kobject cleanup work
   734	 * before freeing module
   735	 */
   736	static int kobj_module_callback(struct notifier_block *nb,
   737					   unsigned long val, void *data)
   738	{
   739		LIST_HEAD(pending);
   740	
 > 741		if (val != MODULE_STATE_GOING)
   742			return NOTIFY_DONE;
   743	
   744		spin_lock_irq(&kobj_cleanup_lock);
   745		list_splice_init(&kobj_cleanup_list, &pending);
   746		spin_unlock_irq(&kobj_cleanup_lock);
   747	
   748		while (!list_empty_careful(&pending))
   749			msleep(jiffies_to_msecs(HZ / 10));
   750	
   751		flush_scheduled_work();
   752		return NOTIFY_DONE;
   753	}
   754	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip