Re: [PATCH v2 2/4] Documentation: DT: bindings: input: Add documentation for cyttsp5

From: Andreas Kemnade
Date: Fri Nov 05 2021 - 10:22:19 EST


Hi,

I finally found time to test this.

On Wed, 3 Nov 2021 21:48:28 +1000
Alistair Francis <alistair@xxxxxxxxxxxxx> wrote:

[...]
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + touchscreen@24 {
> + compatible = "cypress,tt2100";
> + reg = <0x24>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&tp_reset_ds203>;
> + interrupt-parent = <&pio>;
> + interrupts = <1 5 IRQ_TYPE_LEVEL_LOW>;
hmm, in the code is IRQ_TRIGGER_FALLING but here is LEVEL_LOW, hmm what
it is really?

> + reset-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>;

hmm, if the reset gpio at the chip is active low (I guess it is) that
would indicate an inverter between SoC and gpio. So a nonstandard setup
as an example, probably not a good idea.

Regards,
Andreas