Re: [PATCH v2] staging: r8188eu: os_dep: remove the goto statement

[Saurav Girepunje]

On 05/11/21 4:06 pm, Pavel Skripkin wrote:
> On 11/5/21 12:53, Greg KH wrote:
>> Right after this, ret8 is set, but never checked, which looks like a bug
>> to me.  Can you work on fixing that after I take this patch?
Yes, I will send a patch removing a local variable for return value and changing 
the return type of function rtw_init_default_value . As rtw_init_default_value always return 
success and the return value of this function is not checked.
>>
>> thanks,
>>
>> greg k-h
>>
> 
> ret8 is returned from this function, but as I said [1] it can be just removed. It will be always set to _SUCCESS.
> 
> 
> 
> [1] https://lore.kernel.org/linux-staging/f26b4aec-c0a1-8c93-b34e-8b1a36ac81b3@xxxxxxxxx/
> 
> 
Pavel also mentioned to remove the local variable ret8.
> With regards,
> Pavel Skripkin

Thanks,
Saurav