Re: [PATCH v4 1/1] mm/highmem: Remove deprecated kmap_atomic

[Ira Weiny]

On Fri, Nov 05, 2021 at 05:23:11PM +0000, Matthew Wilcox wrote:
> On Fri, Nov 05, 2021 at 09:58:59AM -0700, Ira Weiny wrote:
> > On Fri, Nov 05, 2021 at 04:51:40PM +0000, Matthew Wilcox wrote:
> > > On Fri, Nov 05, 2021 at 01:50:37PM +0000, Matthew Wilcox wrote:
> > > > On Thu, Feb 11, 2021 at 03:56:25PM -0800, Andrew Morton wrote:
> > > > > On Wed, 10 Feb 2021 16:33:07 -0800 Ira Weiny <ira.weiny@xxxxxxxxx> wrote:
> > > > > 
> > > > > > > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> > > > > > 
> > > > > > This already has my signed off by so I'm not going to 'review'.  With Prathu's
> > > > > > testing information I hope this can land.
> > > > > > 
> > > > > > Andrew did you see this patch?
> > > > > 
> > > > > I did now ;)
> > > > > 
> > > > > Tossed onto the post-rc1 pile, thanks,
> > > > 
> > > > This patch seems to have slipped through the gaps for a couple of cycles
> > > > now?  I found a missed spot in it for CONFIG_HIGHMEM:
> > > 
> > > Ugh, sorry, wrong version of the patch.
> > 
> > Check!  Yea this works for me...
> > 
> > I think this should to through as a separate patch because Prathu's has been
> > soaking for some time.  No need to complicate it with this.
> 
> This isn't "complicating Prathu's patch".  This is "fixing up the bit
> that Prathu missed with his patch".  zero_user_segments() should not
> have different rules on HIGHMEM and non-HIGHMEM kernels.
 
What do you mean by 'different rules'?

Oh I see...  Ok yea.

Well this should not be a big deal...

Ira