Re: parisc build failures in mainline kernel

From: Ard Biesheuvel
Date: Fri Nov 05 2021 - 15:44:10 EST


On Fri, 5 Nov 2021 at 20:43, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> On Wed, Nov 03, 2021 at 09:45:47PM -0700, Linus Torvalds wrote:
> > On Wed, Nov 3, 2021 at 9:30 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > >
> > > Unfortunately not. With that patch it complains about task_struct.
> >
> > Gaah. You'll need something like this too
> >
> > - DEFINE(TASK_CPU, offsetof(struct task_struct, cpu));
> > + DEFINE(TASK_CPU, offsetof(struct task_struct, thread_info.cpu));
> >
> > in arch/parisc/kernel/asm-offsets.c.
> >
> > And really, it should probably be renamed as TASK_TI_CPU, but then you
> > have to rename all the uses too.
> >
> > There might be other details like that lurking.
>
> I'll check this out too if Ard doesn't beat me to it. Thanks for the
> investigation and sorry for the breakage!
>

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2a2e8202c7a16a85a881ad2b6e32ccbebdc01dda