Re: [PATCH v2] drivers/coresight: ultrasoc: Add System Memory Buffer driver

[liuqi (BA)]

On 2021/11/5 9:36, Randy Dunlap wrote:
> On 11/4/21 6:20 PM, Qi Liu wrote:
> > diff --git a/drivers/hwtracing/coresight/ultrasoc/Kconfig 
> > b/drivers/hwtracing/coresight/ultrasoc/Kconfig
> > new file mode 100644
> > index 000000000000..c18c25bf9df3
> > --- /dev/null
> > +++ b/drivers/hwtracing/coresight/ultrasoc/Kconfig
> > @@ -0,0 +1,12 @@
> > +# SPDX-License-Identifier: MIT
> > +#
> > +# ultrasoc configuration
> > +#
> > +config ULTRASOC_SMB
> > +    tristate "Ultrasoc system memory buffer drivers"
> > +        depends on ARM64 && CORESIGHT
>
> The "depends" line should be indented with a tab instead of spaces...
ah, yes, my editor might be set incorrectly, thanks for the reminder, 
I'll correct it next time.

Qi
> > +    help
> > +      This enables support for the Ultrasoc system memory buffer
> > +      driver that is responsible for receiving the trace data from
> > +      Coresight ETM devices and storing them to a system buffer
> > +      respectively.