[RFC PATCH v1 1/2] PCI/ASPM: Never enable ASPM for insane devices
From: Saheed O. Bolarinwa
Date: Sat Nov 06 2021 - 13:56:38 EST
aspm_attr_store_common() makes it possible to clear the disable bits
even for devices that fails pcie_aspm_sanity_check().
- Extend the if condition in aspm_attr_store_common() to screen out
insane devices.
Signed-off-by: Saheed O. Bolarinwa <refactormyself@xxxxxxxxx>
---
drivers/pci/pcie/aspm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index 013a47f587ce..72cb17489e88 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -1225,7 +1225,7 @@ static ssize_t aspm_attr_store_common(struct device *dev,
down_read(&pci_bus_sem);
mutex_lock(&aspm_lock);
- if (state_enable) {
+ if (state_enable && !pcie_aspm_sanity_check(pdev)) {
link->aspm_disable &= ~state;
/* need to enable L1 for substates */
if (state & ASPM_STATE_L1SS)
--
2.20.1