Re: [PATCH v3] staging: vt6655: fix camelcase byData in card.c

[Joe Perches]

On Sat, 2021-11-06 at 19:48 +0100, Tommaso Merciai wrote:
> Replace camelcase variable "byData" into linux kernel coding style
> equivalent variable "data" in card.c.
> "by" prefix in hungarian notation stands for byte or unsigned char
[]
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
[]
> @@ -194,15 +194,15 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
>  			priv->abyBBVGA[0] = 0x20;
>  			priv->abyBBVGA[2] = 0x10;
>  			priv->abyBBVGA[3] = 0x10;
> -			bb_read_embedded(priv, 0xE7, &byData);
> -			if (byData == 0x1C)
> +			bb_read_embedded(priv, 0xE7, &data);

It might be nice to figure out what these register values are
and use #defines instead of hard coded values like 0xE7

> +			if (data == 0x1C)
>  				bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]);

etc...