Re: [PATCH v3] tty: vt: keyboard: add default switch-case, to handle smatch-warnings in method vt_do_kdgkb_ioctl

[Ajay Garg]

> >
>
> I am not against these braces, but I, honestly, dislike them, because
> `case : {` syntax looks ugly _to me_.
>
> KDGKBSENT uses it because of local variable `len` and not using them
> will cause build error.

Ahh, that explains the difference.

Floated the v4 patch at :
https://lore.kernel.org/linux-serial/20211107031721.4734-1-ajaygargnsit@xxxxxxxxx/T/#u

so that consistency is maintained in the styling.

Let's continue on the v4-patch link now.

Thanks again Pavel.


>
> I didn't find any strict requirements to not use brackets when there is
> no local variable, so it's up to maintainers (again).
>
>
> Anyway, thank for respinning :)
>
>
>
> With regards,
> Pavel Skripkin