RE: [PATCH v10 0/3] Add driver for lan966x Generic Clock Controller

[Kavyasree.Kotagiri]

Hi Stephen,

Addressed your comments in v10 patch series. 
Please let me know when you include my patches into PR.

Thanks,
Kavya
> -----Original Message-----
> From: Kavyasree Kotagiri [mailto:kavyasree.kotagiri@xxxxxxxxxxxxx]
> Sent: Wednesday, November 3, 2021 11:50 AM
> To: robh+dt@xxxxxxxxxx; mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> clk@xxxxxxxxxxxxxxx; UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>;
> Nicolas Ferre - M43238 <Nicolas.Ferre@xxxxxxxxxxxxx>; Eugen Hristev -
> M18282 <Eugen.Hristev@xxxxxxxxxxxxx>; Kavyasree Kotagiri - I30978
> <Kavyasree.Kotagiri@xxxxxxxxxxxxx>; Manohar Puri - I30488
> <Manohar.Puri@xxxxxxxxxxxxx>
> Subject: [PATCH v10 0/3] Add driver for lan966x Generic Clock Controller
> 
> This patch series adds a device driver for Generic Clock Controller
> of lan966x SoC.
> 
> v9 -> v10:
> - Removed .name from lan966x_gck_pdata struct.
> - Removed "_clk" in fw_names like used in bindings
> 
> v8 -> v9:
> - Added Acked-by to dt-bindings and Documentation file.
> - Changed clk_name "timer" to "timer1"
> - Updated devm_kzalloc in probe function.
> 
> v7 -> v8:
> - Defined new constant DIV_MAX.
> - Corrected and updated prescaler divider condition check.
> - Added Acked-by.
> 
> v6 -> v7:
> - Added Kconfig and Makefile entires for lan966x clock driver.
> 
> v5 -> v6:
> - Added Acked-by to dt-bindings file.
> - Removed "_clk" in clock-names.
> - Added Reviewed-by to Documentation file.
> 
> v4 -> v5:
> - In v4 dt-bindings, missed adding "clock-names" in required
>   properties and example. So, added them.
> - Returning proper error - PTR_ERR.
> - Removed unused variable "ret" in probe function.
> 
> v3 -> v4:
> - Updated "clocks" and added "clock-names" in dt-bindings.
> - Used clk_parent_data instead of of_clk_get_parent_name().
> 
> v2 -> v3:
> - Fixed dt_binding_check errors.
> 
> v1 -> v2:
> - Updated license in dt-bindings.
> - Updated example provided for clock controller node.
> 
> Kavyasree Kotagiri (3):
>   dt-bindings: clock: lan966x: Add binding includes for lan966x SoC
>     clock IDs
>   dt-bindings: clock: lan966x: Add LAN966X Clock Controller
>   clk: lan966x: Add lan966x SoC clock driver
> 
>  .../bindings/clock/microchip,lan966x-gck.yaml |  57 +++++
>  drivers/clk/Kconfig                           |   7 +
>  drivers/clk/Makefile                          |   1 +
>  drivers/clk/clk-lan966x.c                     | 240 ++++++++++++++++++
>  include/dt-bindings/clock/microchip,lan966x.h |  28 ++
>  5 files changed, 333 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/clock/microchip,lan966x-gck.yaml
>  create mode 100644 drivers/clk/clk-lan966x.c
>  create mode 100644 include/dt-bindings/clock/microchip,lan966x.h
> 
> --
> 2.17.1