RE: [PATCH 2/2] mmc: Add mmc driver for Sunplus SP7021

[Tony Huang 黃懷厚]

Dear Randy:
> [resending, had some kind of email error on the first try]
> 
> On 11/6/21 7:23 AM, Tony Huang wrote:
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index
> > ccc148c..2a78cbc 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -14,6 +14,15 @@ config MMC_DEBUG
> >   	  added host drivers please don't invent their private macro for
> >   	  debugging.
> >
> > +config MMC_SUNPLUS
> > +	tristate "Sunplus SP7021 MMC Controller"
> > +	depends on ARCH_SUNPLUS || SOC_I143 || SOC_Q645
> > +	default y
> 
> Is this needed to be able to boot?  That's about the only reason that "default
> y" could be justified.

Yes, it needs to be able to be boot.

> 
> > +	help
> > +		If you say yes here, you will get support for eMMC host interface
> > +		on sunplus Socs.
> 
> 		   Sunplus SoCs.

I will modify.

> 
> > +		If unsure, say N.
> > +		Sunplus  eMMC Host Controller v4.51 support"
> 
> What is that last line for?

I will remove last line.

> 
> And all lines of the help text should be indented with one tab + 2 spaces per
> coding-style.rst.

Ok, I understand

> 
> thanks.
> --
> ~Randy