Re: [PATCH] x86/mce: drop cpu_missing since we have more capable mce_missing_cpus
From: Zhaolong Zhang
Date: Tue Nov 09 2021 - 03:31:43 EST
At 2021-11-08 20:47:59, "Zhaolong Zhang" <zhangzl2013@xxxxxxx> wrote:
>At 2021-11-08 18:31:38, "Borislav Petkov" <bp@xxxxxxxxx> wrote:
>>On Mon, Nov 08, 2021 at 06:13:04PM +0800, Zhaolong Zhang wrote:
>>> I was concerning that if I simply remove the cpu_missing code, we will lose the log in the
>>> situation where mca_cfg.tolerant > 1 and no_way_out is set afterwards.
>>>
>>> Do you think we can safely ignore that situation?
>>
>>Well, how likely is to have such a situation in practice?
>
>It is difficult to answer...
>But since current code is dealing with this situation, I think I should cover it too,
>although it is only a piece of log.
Hi Boris,
I reconsidered the situation.
If there is a non-recoverable mce as well, just let it print that reason. No need to bring the
timeout message indeed. Because since the tolerant was set to a high level to ignore the timeout,
we can eventually ignore them.
So simply drop cpu_missing variable as you mentioned should work.
I am not sure whether it should be authored by you or suggested by you.
Anyway, I will post a new patch exactly as you suggested. Please pick it or ignore it as appropriate :)
Thanks,
Zhaolong