Re: [PATCH v2 1/7] net: dsa: b53: Add BroadSync HD register definitions

From: Kurt Kanzenbach
Date: Tue Nov 09 2021 - 05:10:46 EST


Hi Martin,

On Tue Nov 09 2021, Martin Kaistra wrote:
> From: Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>
>
> Add register definitions for the BroadSync HD features of
> BCM53128. These will be used to enable PTP support.
>
> Signed-off-by: Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>
> Signed-off-by: Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx>
> ---
> drivers/net/dsa/b53/b53_regs.h | 71 ++++++++++++++++++++++++++++++++++
> 1 file changed, 71 insertions(+)
>
> diff --git a/drivers/net/dsa/b53/b53_regs.h b/drivers/net/dsa/b53/b53_regs.h
> index b2c539a42154..0deb11a7c9cd 100644
> --- a/drivers/net/dsa/b53/b53_regs.h
> +++ b/drivers/net/dsa/b53/b53_regs.h
> @@ -50,6 +50,12 @@
> /* Jumbo Frame Registers */
> #define B53_JUMBO_PAGE 0x40
>
> +/* BroadSync HD Register Page */
> +#define B53_BROADSYNC_PAGE 0x90
> +
> +/* Traffic Remarking Register Page */
> +#define B53_TRAFFICREMARKING_PAGE 0x91

That's not used anywhere and could be removed.

Note: The subject prefix for the patches should be net-next to indicate
the tree which you are targeting. See

https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in

Thanks,
Kurt

Attachment: signature.asc
Description: PGP signature