Re: [PATCH 4/5] dt-bindings: net: dwmac: Convert mediatek-dwmac to DT schema

[Biao Huang]

Dear Rob,
	Thanks for your comments~
	I'll check again with updated dtschema, and send in next
version.
	
Best Regards!
Biao

On Wed, 2021-11-10 at 13:44 -0600, Rob Herring wrote:
> On Wed, 10 Nov 2021 16:39:47 +0800, Biao Huang wrote:
> > Convert mediatek-dwmac to DT schema, and delete old mediatek-
> > dwmac.txt.
> > 
> > Signed-off-by: Biao Huang <biao.huang@xxxxxxxxxxxx>
> > ---
> >  .../bindings/net/mediatek-dwmac.txt           |  91 ---------
> >  .../bindings/net/mediatek-dwmac.yaml          | 179
> > ++++++++++++++++++
> >  2 files changed, 179 insertions(+), 91 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/net/mediatek-
> > dwmac.txt
> >  create mode 100644 Documentation/devicetree/bindings/net/mediatek-
> > dwmac.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml:
> properties:mediatek,tx-delay-ps: '$ref' should not be valid under
> {'const': '$ref'}
> 	hint: Standard unit suffix properties don't need a type $ref
> 	from schema $id: http://devicetree.org/meta-schemas/core.yaml#
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml:
> properties:mediatek,rx-delay-ps: '$ref' should not be valid under
> {'const': '$ref'}
> 	hint: Standard unit suffix properties don't need a type $ref
> 	from schema $id: http://devicetree.org/meta-schemas/core.yaml#
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml:
> properties:clocks: {'minItems': 5, 'maxItems': 6, 'items':
> [{'description': 'AXI clock'}, {'description': 'APB clock'},
> {'description': 'MAC clock gate'}, {'description': 'MAC Main clock'},
> {'description': 'PTP clock'}, {'description': 'RMII reference clock
> provided by MAC'}]} should not be valid under {'required':
> ['maxItems']}
> 	hint: "maxItems" is not needed with an "items" list
> 	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml:
> ignoring, error in schema: properties: mediatek,tx-delay-ps
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> Documentation/devicetree/bindings/net/mediatek-
> dwmac.example.dt.yaml:0:0: /example-0/ethernet@1101c000: failed to
> match any schema with compatible: ['mediatek,mt2712-gmac',
> 'snps,dwmac-4.20a']
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/1553304
> 
> This check can fail if there are any dependencies. The base for a
> patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up
> to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
>