Re: [PATCH v3 2/5] spi: dw: Add SSTE support for DWC SSI controller
From: Serge Semin
Date: Thu Nov 11 2021 - 09:16:42 EST
On Thu, Nov 11, 2021 at 01:56:36PM +0000, Mark Brown wrote:
> On Thu, Nov 11, 2021 at 02:51:58PM +0800, nandhini.srikandan@xxxxxxxxx wrote:
> > From: Nandhini Srikandan <nandhini.srikandan@xxxxxxxxx>
> >
> > Add support for Slave Select Toggle Enable (SSTE) in DWC SSI controller
> > via DTS. The slave select line will toggle between consecutive data frames,
> > with the serial clock being held to its default value while slave
> > select line is high.
>
> This should be controlled by SPI_CS_WORD.
Oh, yeah. I've absolutely forgotten about that flag. Indeed then there
is no need in implementing a separate DT-property. In this case the
patchset will need to be fixed a bit: remove the DT-part of the
sste-feature and alter the dw_spi_setup() method so to take the
SPI_CS_WORD flag into account.
Nandhini, sorry about a wrong advice on v2. It seems v4 will be
required...
-Sergey