Re: [PATCH] gpio: xlp: Remove Netlogic XLP variants
From: Rob Herring
Date: Thu Nov 11 2021 - 15:13:48 EST
On Thu, Nov 11, 2021 at 4:43 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Tue, Nov 9, 2021 at 5:12 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> > Netlogic XLP was removed in commit 95b8a5e0111a ("MIPS: Remove NETLOGIC
> > support"). With those gone, the single platform left to support is
> > Cavium ThunderX2. Remove all the Netlogic variants and DT support.
> >
> > For simplicity, the existing kconfig name is retained.
> >
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > Cc: Bartosz Golaszewski <brgl@xxxxxxxx>
> > Cc: linux-gpio@xxxxxxxxxxxxxxx
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> A question:
>
>
> > @@ -373,7 +263,7 @@ static int xlp_gpio_probe(struct platform_device *pdev)
> > gc->label = dev_name(&pdev->dev);
> > gc->base = 0;
>
> Can we also set this to -1 and use dynamic GPIO base allocation?
> (Can be a separate patch.)
No clue. What's normal for GPIO ACPI systems? Does that mean more than
1 instance is broken currently?
Rob