Re: [PATCH v3 3/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add RPM and fixed regulators

[Konrad Dybcio]

On 11.11.2021 04:16, Dang Huynh wrote:
> Subject:
> [PATCH v3 3/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add RPM and fixed regulators
> From:
> Dang Huynh <danct12@xxxxxxxxxx>
> Date:
> 11.11.2021, 04:16
> 
> To:
> Dang Huynh <danct12@xxxxxxxxxx>
> CC:
> Andy Gross <agross@xxxxxxxxxx>, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, linux-arm-msm@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Alexey Min <alexey.min@xxxxxxxxx>, Caleb Connolly <caleb@xxxxxxxxxxxxx>, Martin Botka <martin.botka@xxxxxxxxxxxxxx>, Konrad Dybcio <konradybcio@xxxxxxxxx>
> 
> 
> Add most of the RPM PM660/PM660L regulators and the fixed ones,
> defining the common electrical part of this platform.
> 
> Reviewed-by: Caleb Connolly <caleb@xxxxxxxxxxxxx>
> Reviewed-by: Konrad Dybcio <konradybcio@xxxxxxxxx>
As explained by Marijn in an email in this thread, please drop this line, as I did not approve the patch,
and definitely not from that email :P


> +
> +		vreg_s1b_1p125: s1 {
> +			regulator-min-microvolt = <1125000>;
> +			regulator-max-microvolt = <1125000>;
> +			regulator-enable-ramp-delay = <200>;
> +			regulator-ramp-delay = <0>;
I don't think setting a ramp delay of 0 does anything, this goes for every instance of this in the patch.


Konrad