RE: [PATCH v2 RESEND 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv"

[Limonciello, Mario]

[Public]



> -----Original Message-----
> From: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Sent: Friday, November 5, 2021 10:02
> To: Pandey, Ajit Kumar <AjitKumar.Pandey@xxxxxxx>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxx>; linux-clk <linux-clk@xxxxxxxxxxxxxxx>;
> Mukunda, Vijendar <Vijendar.Mukunda@xxxxxxx>; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>; Hiregoudar, Basavaraj
> <Basavaraj.Hiregoudar@xxxxxxx>; Dommati, Sunil-kumar <Sunil-
> kumar.Dommati@xxxxxxx>; Rafael J. Wysocki <rafael@xxxxxxxxxx>; Len
> Brown <lenb@xxxxxxxxxx>; open list:ACPI <linux-acpi@xxxxxxxxxxxxxxx>; open
> list <linux-kernel@xxxxxxxxxxxxxxx>; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx>
> Subject: Re: [PATCH v2 RESEND 2/5] drivers: acpi: acpi_apd: Remove unused
> device property "is-rv"
> 
> On Fri, Oct 29, 2021 at 8:33 AM Ajit Kumar Pandey
> <AjitKumar.Pandey@xxxxxxx> wrote:
> >
> > Initially "is-rv" device property is added for 48MHz fixed clock
> > support on Raven or RV architecture. It's unused now as we moved
> > to clock config based selection to extend such support on others
> > architecture. This change removed unused code from acpi driver.
> >
> > Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@xxxxxxx>
> 
> Is this and the [3/5] applicable without the [1/5]?
> 
> If so, I can pick them up once they are approved by some other AMD
> folks, preferably Mario.

I had some offline conversations with Ajit, and gave them some other
ideas instead of Kconfig based clock settings.  Let's wait for the result
of those tries.

> 
> > ---
> >  drivers/acpi/acpi_apd.c               | 3 ---
> >  include/linux/platform_data/clk-fch.h | 1 -
> >  2 files changed, 4 deletions(-)
> >
> > diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> > index 6e02448d15d9..6913e9712852 100644
> > --- a/drivers/acpi/acpi_apd.c
> > +++ b/drivers/acpi/acpi_apd.c
> > @@ -87,9 +87,6 @@ static int fch_misc_setup(struct apd_private_data
> *pdata)
> >         if (ret < 0)
> >                 return -ENOENT;
> >
> > -       if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj))
> > -               clk_data->is_rv = obj->integer.value;
> > -
> >         list_for_each_entry(rentry, &resource_list, node) {
> >                 clk_data->base = devm_ioremap(&adev->dev, rentry->res->start,
> >                                               resource_size(rentry->res));
> > diff --git a/include/linux/platform_data/clk-fch.h
> b/include/linux/platform_data/clk-fch.h
> > index b9f682459f08..850ca776156d 100644
> > --- a/include/linux/platform_data/clk-fch.h
> > +++ b/include/linux/platform_data/clk-fch.h
> > @@ -12,7 +12,6 @@
> >
> >  struct fch_clk_data {
> >         void __iomem *base;
> > -       u32 is_rv;
> >  };
> >
> >  #endif /* __CLK_FCH_H */
> > --
> > 2.25.1
> >