Re: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()

From: Jonathan Cameron
Date: Sat Nov 13 2021 - 11:42:38 EST


On Fri, 5 Nov 2021 01:55:04 +0000
Xu Wang <vulab@xxxxxxxxxxx> wrote:

> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Xu Wang <vulab@xxxxxxxxxxx>
Applied, thanks

Jonathan
> ---
> drivers/iio/adc/rzg2l_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c
> index 32fbf57c362f..9d5be52bd948 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "no irq resource\n");
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_irq(dev, irq, rzg2l_adc_isr,
> 0, dev_name(dev), adc);