[driver-core:debugfs_cleanup 1/1] fs/d_path.c:20:20: warning: Unsigned variable '.' can't be negative so it is unnecessary to test it. [unsignedPositive]
From: kernel test robot
Date: Mon Nov 15 2021 - 04:25:38 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup
head: 8247270bcf99bc7bf661ae2a3f2ee6e64c7f957d
commit: 8247270bcf99bc7bf661ae2a3f2ee6e64c7f957d [1/1] fs: make d_path-like functions all have unsigned size
compiler: ia64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> fs/d_path.c:20:20: warning: Unsigned variable '.' can't be negative so it is unnecessary to test it. [unsignedPositive]
if (likely(p->len >= 0))
^
vim +20 fs/d_path.c
7a5cf791a74764 Al Viro 2018-03-05 10
ad08ae586586ea Al Viro 2021-05-12 11 struct prepend_buffer {
ad08ae586586ea Al Viro 2021-05-12 12 char *buf;
8247270bcf99bc Greg Kroah-Hartman 2021-07-27 13 unsigned int len;
ad08ae586586ea Al Viro 2021-05-12 14 };
ad08ae586586ea Al Viro 2021-05-12 15 #define DECLARE_BUFFER(__name, __buf, __len) \
ad08ae586586ea Al Viro 2021-05-12 16 struct prepend_buffer __name = {.buf = __buf + __len, .len = __len}
ad08ae586586ea Al Viro 2021-05-12 17
ad08ae586586ea Al Viro 2021-05-12 18 static char *extract_string(struct prepend_buffer *p)
7a5cf791a74764 Al Viro 2018-03-05 19 {
ad08ae586586ea Al Viro 2021-05-12 @20 if (likely(p->len >= 0))
ad08ae586586ea Al Viro 2021-05-12 21 return p->buf;
ad08ae586586ea Al Viro 2021-05-12 22 return ERR_PTR(-ENAMETOOLONG);
ad08ae586586ea Al Viro 2021-05-12 23 }
ad08ae586586ea Al Viro 2021-05-12 24
:::::: The code at line 20 was first introduced by commit
:::::: ad08ae586586ea9e2c0228a3d5a083500ea54202 d_path: introduce struct prepend_buffer
:::::: TO: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
:::::: CC: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx