Re: [PATCH] panic: use error_report_end tracepoint on warnings
From: Andy Shevchenko
Date: Mon Nov 15 2021 - 09:39:14 EST
On Mon, Nov 15, 2021 at 09:56:30AM +0100, Marco Elver wrote:
> Introduce the error detector "warning" to the error_report event and use
> the error_report_end tracepoint at the end of a warning report.
>
> This allows in-kernel tests but also userspace to more easily determine
> if a warning occurred without polling kernel logs.
...
> enum error_detector {
> ERROR_DETECTOR_KFENCE,
> - ERROR_DETECTOR_KASAN
> + ERROR_DETECTOR_KASAN,
> + ERROR_DETECTOR_WARN
...which exactly shows my point (given many times somewhere else) why comma
is good to have when we are not sure the item is a terminator one in the enum
or array of elements.
> };
--
With Best Regards,
Andy Shevchenko